Skip to content

fix: LevelDB transaction nil panic#99

Merged
nasdf merged 14 commits intosourcenetwork:mainfrom
nasdf:feat/leveldb
Dec 3, 2025
Merged

fix: LevelDB transaction nil panic#99
nasdf merged 14 commits intosourcenetwork:mainfrom
nasdf:feat/leveldb

Conversation

@nasdf
Copy link
Member

@nasdf nasdf commented Dec 2, 2025

Description

I forgot to add a nil check here. This PR also bumps the goleveldb version since it includes a fix for a data race.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/validate-conventional-style.sh.
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Integration tests

Specify the platform(s) on which this was tested:

  • MacOS

@nasdf nasdf self-assigned this Dec 2, 2025
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nasdf nasdf merged commit f8be807 into sourcenetwork:main Dec 3, 2025
156 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants