Skip to content

Test meta-schema validation of invalid $vocabulary#789

Merged
jviotti merged 3 commits intomainfrom
vocabulary-invalid
Mar 26, 2026
Merged

Test meta-schema validation of invalid $vocabulary#789
jviotti merged 3 commits intomainfrom
vocabulary-invalid

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Mar 26, 2026

Signed-off-by: Juan Cruz Viotti [email protected]

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@augmentcode
Copy link

augmentcode bot commented Mar 26, 2026

🤖 Augment PR Summary

Summary: Adds a regression test ensuring metaschema validation fails when $vocabulary is not an object.

Changes:

  • Register fail-vocabulary-not-object in the CLI index test suite.
  • Create a temporary custom Draft 2020-12 metaschema with $vocabulary set to a string.
  • Run one index (concurrency 1), normalize thread annotations, and assert exit code 1 plus the expected diagnostics.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@jviotti jviotti force-pushed the vocabulary-invalid branch from 129510f to 44c4076 Compare March 26, 2026 19:19
jviotti added 2 commits March 26, 2026 15:23
Signed-off-by: Juan Cruz Viotti <[email protected]>
Signed-off-by: Juan Cruz Viotti <[email protected]>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: f3bbdd4 Previous: e9f466c Ratio
Add one schema (0 existing) 17 ms 20 ms 0.85
Add one schema (100 existing) 21 ms 25 ms 0.84
Add one schema (1000 existing) 65 ms 84 ms 0.77
Add one schema (10000 existing) 563 ms 674 ms 0.84
Update one schema (1 existing) 16 ms 18 ms 0.89
Update one schema (101 existing) 21 ms 27 ms 0.78
Update one schema (1001 existing) 70 ms 79 ms 0.89
Update one schema (10001 existing) 564 ms 673 ms 0.84
Cached rebuild (1 existing) 9 ms 10 ms 0.90
Cached rebuild (101 existing) 11 ms 12 ms 0.92
Cached rebuild (1001 existing) 24 ms 34 ms 0.71
Cached rebuild (10001 existing) 179 ms 280 ms 0.64
Index 100 schemas 86 ms 150 ms 0.57
Index 1000 schemas 724 ms 1115 ms 0.65
Index 10000 schemas 11390 ms 14448 ms 0.79

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit ff84978 into main Mar 26, 2026
6 checks passed
@jviotti jviotti deleted the vocabulary-invalid branch March 26, 2026 19:52
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: f3bbdd4 Previous: e9f466c Ratio
Add one schema (0 existing) 22 ms 21 ms 1.05
Add one schema (100 existing) 30 ms 26 ms 1.15
Add one schema (1000 existing) 86 ms 77 ms 1.12
Add one schema (10000 existing) 708 ms 624 ms 1.13
Update one schema (1 existing) 21 ms 19 ms 1.11
Update one schema (101 existing) 32 ms 26 ms 1.23
Update one schema (1001 existing) 87 ms 78 ms 1.12
Update one schema (10001 existing) 715 ms 647 ms 1.11
Cached rebuild (1 existing) 12 ms 11 ms 1.09
Cached rebuild (101 existing) 15 ms 13 ms 1.15
Cached rebuild (1001 existing) 39 ms 34 ms 1.15
Cached rebuild (10001 existing) 306 ms 264 ms 1.16
Index 100 schemas 153 ms 115 ms 1.33
Index 1000 schemas 1096 ms 952 ms 1.15
Index 10000 schemas 13502 ms 14023 ms 0.96

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant