Skip to content

Test that $vocabulary on pre 2019-09 is ignored#788

Merged
jviotti merged 1 commit intomainfrom
vocabulary-ignore
Mar 26, 2026
Merged

Test that $vocabulary on pre 2019-09 is ignored#788
jviotti merged 1 commit intomainfrom
vocabulary-ignore

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Mar 26, 2026

Signed-off-by: Juan Cruz Viotti [email protected]

@augmentcode
Copy link

augmentcode bot commented Mar 26, 2026

🤖 Augment PR Summary

Summary: This PR adds a new CLI regression test to ensure that the $vocabulary keyword is ignored when indexing schemas that declare a pre-2019-09 dialect (Draft-04).

Changes:

  • Registers a new CLI test target in test/cli/CMakeLists.txt
  • Adds test/cli/index/common/draft4-ignore-vocabulary.sh which indexes a Draft-04 schema containing an unknown $vocabulary entry
  • Asserts the index run succeeds and produces the expected deterministic progress output (with thread info stripped)

Technical Notes: The test runs with --concurrency 1 and normalizes stderr output to keep the diff stable across platforms.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: ee12c72 Previous: 99ae139 Ratio
Add one schema (0 existing) 18 ms 23 ms 0.78
Add one schema (100 existing) 23 ms 28 ms 0.82
Add one schema (1000 existing) 62 ms 86 ms 0.72
Add one schema (10000 existing) 669 ms 704 ms 0.95
Update one schema (1 existing) 17 ms 21 ms 0.81
Update one schema (101 existing) 22 ms 29 ms 0.76
Update one schema (1001 existing) 65 ms 94 ms 0.69
Update one schema (10001 existing) 533 ms 707 ms 0.75
Cached rebuild (1 existing) 10 ms 12 ms 0.83
Cached rebuild (101 existing) 11 ms 14 ms 0.79
Cached rebuild (1001 existing) 24 ms 40 ms 0.60
Cached rebuild (10001 existing) 178 ms 302 ms 0.59
Index 100 schemas 93 ms 132 ms 0.70
Index 1000 schemas 778 ms 1056 ms 0.74
Index 10000 schemas 10973 ms 14224 ms 0.77

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: ee12c72 Previous: 99ae139 Ratio
Add one schema (0 existing) 20 ms 21 ms 0.95
Add one schema (100 existing) 26 ms 25 ms 1.04
Add one schema (1000 existing) 78 ms 84 ms 0.93
Add one schema (10000 existing) 683 ms 732 ms 0.93
Update one schema (1 existing) 19 ms 19 ms 1
Update one schema (101 existing) 27 ms 26 ms 1.04
Update one schema (1001 existing) 83 ms 87 ms 0.95
Update one schema (10001 existing) 710 ms 731 ms 0.97
Cached rebuild (1 existing) 11 ms 10 ms 1.10
Cached rebuild (101 existing) 13 ms 15 ms 0.87
Cached rebuild (1001 existing) 34 ms 37 ms 0.92
Cached rebuild (10001 existing) 274 ms 297 ms 0.92
Index 100 schemas 116 ms 116 ms 1
Index 1000 schemas 913 ms 1099 ms 0.83
Index 10000 schemas 13796 ms 13792 ms 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit e9f466c into main Mar 26, 2026
6 checks passed
@jviotti jviotti deleted the vocabulary-ignore branch March 26, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant