Reject meta-schemas with unknown required vocabularies even if not used#782
Draft
Reject meta-schemas with unknown required vocabularies even if not used#782
Conversation
🤖 Augment PR SummarySummary: Improves how the CLI reports Blaze compilation failures caused by schemas requiring unsupported vocabularies. Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
Contributor
There was a problem hiding this comment.
Benchmark Index (community)
Details
| Benchmark suite | Current: a3b200d | Previous: 27a390b | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
19 ms |
19 ms |
1 |
Add one schema (100 existing) |
25 ms |
26 ms |
0.96 |
Add one schema (1000 existing) |
77 ms |
77 ms |
1 |
Add one schema (10000 existing) |
660 ms |
660 ms |
1 |
Update one schema (1 existing) |
18 ms |
20 ms |
0.90 |
Update one schema (101 existing) |
25 ms |
27 ms |
0.93 |
Update one schema (1001 existing) |
79 ms |
79 ms |
1 |
Update one schema (10001 existing) |
683 ms |
667 ms |
1.02 |
Cached rebuild (1 existing) |
10 ms |
10 ms |
1 |
Cached rebuild (101 existing) |
12 ms |
12 ms |
1 |
Cached rebuild (1001 existing) |
34 ms |
33 ms |
1.03 |
Cached rebuild (10001 existing) |
269 ms |
265 ms |
1.02 |
Index 100 schemas |
126 ms |
163 ms |
0.77 |
Index 1000 schemas |
1079 ms |
1166 ms |
0.93 |
Index 10000 schemas |
13841 ms |
14141 ms |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Benchmark Index (enterprise)
Details
| Benchmark suite | Current: a3b200d | Previous: 27a390b | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
22 ms |
24 ms |
0.92 |
Add one schema (100 existing) |
29 ms |
27 ms |
1.07 |
Add one schema (1000 existing) |
89 ms |
79 ms |
1.13 |
Add one schema (10000 existing) |
753 ms |
648 ms |
1.16 |
Update one schema (1 existing) |
20 ms |
20 ms |
1 |
Update one schema (101 existing) |
28 ms |
26 ms |
1.08 |
Update one schema (1001 existing) |
91 ms |
79 ms |
1.15 |
Update one schema (10001 existing) |
752 ms |
652 ms |
1.15 |
Cached rebuild (1 existing) |
12 ms |
11 ms |
1.09 |
Cached rebuild (101 existing) |
14 ms |
13 ms |
1.08 |
Cached rebuild (1001 existing) |
40 ms |
35 ms |
1.14 |
Cached rebuild (10001 existing) |
315 ms |
270 ms |
1.17 |
Index 100 schemas |
123 ms |
118 ms |
1.04 |
Index 1000 schemas |
1009 ms |
1015 ms |
0.99 |
Index 10000 schemas |
14505 ms |
13204 ms |
1.10 |
This comment was automatically generated by workflow using github-action-benchmark.
49519f9 to
d960e71
Compare
1ac1100 to
43aac1c
Compare
f84a688 to
cc1bf4c
Compare
Signed-off-by: Juan Cruz Viotti <[email protected]>
cc1bf4c to
a3b200d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti [email protected]