Upgrade Blaze to 079b9d438b37ee40966730c79a498abda84c04f8 - #1253
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
|
This pull request is abnormally large and would use a significant amount of tokens to review. If you still wish to review it, comment "augment review" and we will review it. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 351 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/index/generators.h">
<violation number="1" location="src/index/generators.h:83">
P2: When a metaschema declares an unknown base dialect, this now throws instead of returning early. The old code checked `base_dialect()` for nullopt and returned gracefully; the replacement calls `SchemaFrame::analyse()`, which throws `SchemaUnknownBaseDialectError` on that same unknown-dialect case (vendor/blaze/src/foundation/frame.cc:630). Schemas that previously indexed are now rejected during generation.</violation>
</file>
Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
Re-trigger cubic
| sourcemeta::blaze::SchemaBaseDialect::JSON_Schema_2019_09_Hyper) { | ||
| sourcemeta::blaze::SchemaFrame frame{ | ||
| sourcemeta::blaze::SchemaFrame::Mode::Root}; | ||
| frame.analyse(schema, sourcemeta::blaze::schema_walker, resolver, dialect); |
There was a problem hiding this comment.
P2: When a metaschema declares an unknown base dialect, this now throws instead of returning early. The old code checked base_dialect() for nullopt and returned gracefully; the replacement calls SchemaFrame::analyse(), which throws SchemaUnknownBaseDialectError on that same unknown-dialect case (vendor/blaze/src/foundation/frame.cc:630). Schemas that previously indexed are now rejected during generation.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/index/generators.h, line 83:
<comment>When a metaschema declares an unknown base dialect, this now throws instead of returning early. The old code checked `base_dialect()` for nullopt and returned gracefully; the replacement calls `SchemaFrame::analyse()`, which throws `SchemaUnknownBaseDialectError` on that same unknown-dialect case (vendor/blaze/src/foundation/frame.cc:630). Schemas that previously indexed are now rejected during generation.</comment>
<file context>
@@ -79,19 +78,15 @@ static auto throw_if_unknown_required_vocabulary(
- sourcemeta::blaze::SchemaBaseDialect::JSON_Schema_2019_09_Hyper) {
+ sourcemeta::blaze::SchemaFrame frame{
+ sourcemeta::blaze::SchemaFrame::Mode::Root};
+ frame.analyse(schema, sourcemeta::blaze::schema_walker, resolver, dialect);
+ const auto base{frame.root_location().value().get().base_dialect};
+
</file context>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark (community)
Details
| Benchmark suite | Current: ff77625 | Previous: 6b8c561 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
331 ms |
324 ms |
1.02 |
Add one schema (100 existing) |
43 ms |
44 ms |
0.98 |
Add one schema (1000 existing) |
111 ms |
98 ms |
1.13 |
Add one schema (10000 existing) |
717 ms |
1013 ms |
0.71 |
Update one schema (1 existing) |
30 ms |
30 ms |
1 |
Update one schema (101 existing) |
38 ms |
38 ms |
1 |
Update one schema (1001 existing) |
116 ms |
97 ms |
1.20 |
Update one schema (10001 existing) |
741 ms |
956 ms |
0.78 |
Cached rebuild (1 existing) |
9 ms |
9 ms |
1 |
Cached rebuild (101 existing) |
15 ms |
15 ms |
1 |
Cached rebuild (1001 existing) |
39 ms |
46 ms |
0.85 |
Cached rebuild (10001 existing) |
305 ms |
377 ms |
0.81 |
Index 100 schemas |
640 ms |
617 ms |
1.04 |
Index 1000 schemas |
1465 ms |
1421 ms |
1.03 |
Index 10000 schemas |
13024 ms |
12644 ms |
1.03 |
Index 10000 schemas (custom meta-schema) |
15369 ms |
14706 ms |
1.05 |
Index 10000 schemas ($ref fan-out) |
15686 ms |
14929 ms |
1.05 |
test/e2e/html: Schema Fetch (p50) |
413 us |
392 us |
1.05 |
test/e2e/html: Schema Fetch (p99) |
504 us |
473 us |
1.07 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Benchmark (enterprise)
Details
| Benchmark suite | Current: ff77625 | Previous: 6b8c561 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
375 ms |
389 ms |
0.96 |
Add one schema (100 existing) |
111 ms |
115 ms |
0.97 |
Add one schema (1000 existing) |
179 ms |
167 ms |
1.07 |
Add one schema (10000 existing) |
786 ms |
753 ms |
1.04 |
Update one schema (1 existing) |
108 ms |
104 ms |
1.04 |
Update one schema (101 existing) |
114 ms |
113 ms |
1.01 |
Update one schema (1001 existing) |
175 ms |
167 ms |
1.05 |
Update one schema (10001 existing) |
809 ms |
771 ms |
1.05 |
Cached rebuild (1 existing) |
10 ms |
13 ms |
0.77 |
Cached rebuild (101 existing) |
14 ms |
15 ms |
0.93 |
Cached rebuild (1001 existing) |
30 ms |
41 ms |
0.73 |
Cached rebuild (10001 existing) |
207 ms |
309 ms |
0.67 |
Index 100 schemas |
455 ms |
657 ms |
0.69 |
Index 1000 schemas |
1293 ms |
1424 ms |
0.91 |
Index 10000 schemas |
12392 ms |
13173 ms |
0.94 |
Index 10000 schemas (custom meta-schema) |
15572 ms |
15721 ms |
0.99 |
Index 10000 schemas ($ref fan-out) |
15647 ms |
15847 ms |
0.99 |
enterprise/e2e/auth: Schema Anonymous (p50) |
285 us |
420 us |
0.68 |
enterprise/e2e/auth: Schema Anonymous (p99) |
385 us |
535 us |
0.72 |
enterprise/e2e/auth: Schema API Key Identity (p50) |
286 us |
424 us |
0.67 |
enterprise/e2e/auth: Schema API Key Identity (p99) |
376 us |
525 us |
0.72 |
enterprise/e2e/auth: Schema API Key SHA256 (p50) |
302 us |
429 us |
0.70 |
enterprise/e2e/auth: Schema API Key SHA256 (p99) |
401 us |
542 us |
0.74 |
enterprise/e2e/auth: Schema JWT (p50) |
463 us |
553 us |
0.84 |
enterprise/e2e/auth: Schema JWT (p99) |
632 us |
715 us |
0.88 |
test/e2e/html: Schema Fetch (p50) |
295 us |
415 us |
0.71 |
test/e2e/html: Schema Fetch (p99) |
388 us |
501 us |
0.77 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com