Remove old V1 symbol parser, speedtest, and sample indexes#365
Merged
Conversation
- Delete ParsePartialSymbolV1ToBeDeleted and its compat test - Delete speedtest binary and sample-indexes.nix infrastructure - Move identifier helpers from internal/shared to scip package - Remove entire internal/ directory - Clean up flake.nix and checks.nix references
jupblb
force-pushed
the
michal/ParsePartialSymbolV1ToBeDeleted
branch
from
ce8c2b5 to
c40ed6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleted
ParsePartialSymbolV1ToBeDeleted. This implicated deletion ofcompat_test.goandspeedtest_main.go. This implicated deletion ofsample_indexes.go.