Conversation
c0fc85d to
8ee0dcd
Compare
|
Do we really want CI to fail on an unrelated PR, because some Rust dependency had an update in the meantime? I'd think a lockfile really only makes sense when you're talking about a binary, whereas the bindings in here are used as a dependency, meaning the downstream application is going to pick the versions of transitive dependencies. |
|
@kritzcreek OK yeah, it might be too aggressive. The problem we had originally was the protobuf dependency constraint, and the version of this library itself, had changed and that wasn't reflected in the lockfile. |
|
@kritzcreek I'll close this for now. If the problem persists we can revisit a more balanced take. |
|
SGTM, I think checking in the lock file for reproducible CI is probably a good idea. FWIW the lockfile in here does not affect what versions end up being picked in the downstream build in sg/sg. |
Fails in CI if Cargo.lock is stale:
Fixes https://linear.app/sourcegraph/issue/GRAPH-1125/stale-cargo-lock-file-for-scip-bindings
Test plan