Added NVMe support#1
Conversation
I added an NVME variable that adds a p to the partition if the disk is an NVMe disk.
|
I think interactive approach will make script to grow to enormous size. I would prefer just simple variable that user can change if she/he need, or even automatic discovery. |
|
I think an interactive approach is better because, although the file might grow big, it is easier for intermediate-level Linux users to install Gentoo. |
Also, what about non-binary people? |
|
I would keep this script as simple as possible. Fully interactive swiss knife will be definitely useful (given that even ArchLinux has moved into this direction) but it will be completely different story, the story you can start in your fork ;-) |
|
As per issue #7, requesting this PR be closed as maintainer does not want this script to be interactive. |
I added an NVME variable that adds a p to the partition if the disk is an NVMe disk.