Skip to content

Added NVMe support#1

Open
TheFreePenguin wants to merge 1 commit into
sormy:mainlinefrom
TheFreePenguin:patch-1
Open

Added NVMe support#1
TheFreePenguin wants to merge 1 commit into
sormy:mainlinefrom
TheFreePenguin:patch-1

Conversation

@TheFreePenguin
Copy link
Copy Markdown

I added an NVME variable that adds a p to the partition if the disk is an NVMe disk.

I added an NVME variable that adds a p to the partition if the disk is an NVMe disk.
@sormy
Copy link
Copy Markdown
Owner

sormy commented Apr 13, 2021

I think interactive approach will make script to grow to enormous size. I would prefer just simple variable that user can change if she/he need, or even automatic discovery.

@TheFreePenguin
Copy link
Copy Markdown
Author

I think an interactive approach is better because, although the file might grow big, it is easier for intermediate-level Linux users to install Gentoo.

@TheFreePenguin
Copy link
Copy Markdown
Author

I think interactive approach will make script to grow to enormous size. I would prefer just simple variable that user can change if she/he need, or even automatic discovery.

Also, what about non-binary people?

@sormy
Copy link
Copy Markdown
Owner

sormy commented Apr 13, 2021

I would keep this script as simple as possible. Fully interactive swiss knife will be definitely useful (given that even ArchLinux has moved into this direction) but it will be completely different story, the story you can start in your fork ;-)

@jason-oliveira
Copy link
Copy Markdown

As per issue #7, requesting this PR be closed as maintainer does not want this script to be interactive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants