Merged
Conversation
Co-authored-by: jonathan-r-thorpe <64410119+jonathan-r-thorpe@users.noreply.github.com>
Co-authored-by: jonathan-r-thorpe <64410119+jonathan-r-thorpe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running the testsite against Windows Registry (Visual Studio 2022 (Version 17.13.6)) on IS-04-02 test_32, the tests occasionally failed due to an incorrect received_time during the re-registration of the same resource with a different version.
The failures were accompanied by a log entry from the Registry:
The error is originating in registration_api.cpp
nmos-cpp/Development/nmos/registration_api.cpp
Line 299 in 113e491
The failure of test_23 is intermittent, but can be reproduced reliably by sticking a loop around lines 2119 to 2128 of the test code (looping 300 times seemed to do the job)
https://github.com/AMWA-TV/nmos-testing/blob/f47247ac236b3080711219b407413e45e0b309fe/nmostesting/suites/IS0402Test.py#L2119
The problem seems to occur only in Windows, specifically with the boost version of time_point::now, which sometimes returns the same value even after a small increment of time. This issue does not seem to be happening when using the std::chrono for the time implementation.