Fix extract_log crash on unparseable syslog lines from logrotate race#24114
Open
JibinBao wants to merge 1 commit intosonic-net:masterfrom
Open
Fix extract_log crash on unparseable syslog lines from logrotate race#24114JibinBao wants to merge 1 commit intosonic-net:masterfrom
JibinBao wants to merge 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Replace the hard assert in convert_date() with a warning log so that
lines with unparseable dates (e.g. split/truncated fragments caused by
logrotate race conditions) are logged and skipped instead of crashing
the entire LogAnalyzer teardown. When dt is None, set it to 0 to avoid exceptions during comparison.
Signed-off-by: jbao <jbao@nvidia.com>
JibinBao
force-pushed
the
fix_extract_log
branch
from
c964378 to
1ca1bcb
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nhe-NV
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Print warning log so that lines with unparseable dates (e.g. split/truncated fragments caused by logrotate race conditions) are logged and skipped instead of crashing the entire LogAnalyzer teardown. When dt is None, set it to 0 to avoid exceptions during comparison.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Print warning log so that lines with unparseable dates
How did you do it?
print it
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation