[upgrade_sonic][chassis]: reboot sup seperately#24112
Open
liamkearney-msft wants to merge 2 commits intosonic-net:masterfrom
Open
[upgrade_sonic][chassis]: reboot sup seperately#24112liamkearney-msft wants to merge 2 commits intosonic-net:masterfrom
liamkearney-msft wants to merge 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Javier-Tan
previously approved these changes
Apr 22, 2026
Contributor
Javier-Tan
left a comment
Javier-Tan
left a comment
There was a problem hiding this comment.
LGTM - this is a good change and imitates "proper procedure" / how we expect T2 chassis image upgrade to be done
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Liam Kearney <liamkearney@microsoft.com>
liamkearney-msft
force-pushed
the
pub-dev/upgrade-chassis-reboot
branch
from
0bc83e6 to
a8fce1e
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Liam Kearney <liamkearney@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Existing implementation of upgrade sonic will upgrade then reboot all duts in parallel. For chassis systems this can put linecards in a bad state if the sup reboots before the LCs have finished doing their thing / the sup reboots while LCs are doing first boot initialisation.
For Chassis, update/reboot linecards first, then do the supervisor
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation