Validate paths for Get Requests for mixed_db_client.go#653
Merged
zbud-msft merged 2 commits intosonic-net:masterfrom Apr 21, 2026
Merged
Validate paths for Get Requests for mixed_db_client.go#653zbud-msft merged 2 commits intosonic-net:masterfrom
zbud-msft merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Zain Budhwani <zainbudhwani@microsoft.com>
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends gNMI Get path validation to MixedDbClient so native-origin (“sonic-db”) Get requests return NOT_FOUND semantics for non-existent data, aligning behavior with the earlier DbClient path validation changes from #639.
Changes:
- Added
validateTablePathsExistto verify resolved Redis entities exist before servingMixedDbClient.Get. - Wired validation into
MixedDbClient.Getprior to reading data from Redis.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hdwhdw
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
#639 did not validate paths for mixed db clients, only for db clients.
How I did it
Validate GET paths exist for mixed_db_client
How to verify it
UT/CI
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)