Skip to content

Decouple diff-cover enforcement from integration test job #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hdwhdw merged 5 commits into from
Apr 21, 2026
Merged

Decouple diff-cover enforcement from integration test job #648

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9cd51bd
Move diff-cover enforcement from build job to DiffCoverageCheck
hdwhdw Apr 13, 2026
7449deb
Merge remote-tracking branch 'origin/master' into diff-coverage
hdwhdw Apr 17, 2026
4d96995
Rename build job to IntegrationTest
hdwhdw Apr 17, 2026
28db64a
Use 'build' as job id for DiffCoverageCheck
hdwhdw Apr 20, 2026
1f3c144
Set displayName to 'build' for diff-cover job
hdwhdw Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 28 additions & 9 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ variables:
value: $(Build.SourceBranchName)
- name: UNIT_TEST_FLAG
value: 'ENABLE_TRANSLIB_WRITE=y'
- name: DIFF_COVER_WORKING_DIRECTORY
value: $(System.DefaultWorkingDirectory)/sonic-gnmi


resources:
repositories:
Expand Down Expand Up @@ -158,19 +157,14 @@ stages:
testRunTitle: 'Memory Leak Tests'

# Full integration testing with SONiC dependencies
- job: build
displayName: "build"
- job: IntegrationTest
displayName: "Integration Tests"
timeoutInMinutes: 60

pool:
name: sonicso1ES-amd64
vmImage: ubuntu-22.04

variables:
DIFF_COVER_CHECK_THRESHOLD: 80
DIFF_COVER_ENABLE: 'true'
DIFF_COVER_WORKING_DIRECTORY: $(System.DefaultWorkingDirectory)/sonic-gnmi

container:
image: sonicdev-microsoft.azurecr.io:443/sonic-slave-trixie:latest

Expand Down Expand Up @@ -250,6 +244,31 @@ stages:
displayName: 'Publish integration coverage artifact'
condition: always()

- job: build
displayName: "build"
dependsOn: [PureCIJob, IntegrationTest]
condition: and(succeeded(), eq(variables['Build.Reason'], 'PullRequest'))
timeoutInMinutes: 10

pool:
vmImage: ubuntu-22.04

variables:
DIFF_COVER_ENABLE: 'true'
DIFF_COVER_CHECK_THRESHOLD: 80
DIFF_COVER_WORKING_DIRECTORY: $(System.DefaultWorkingDirectory)
Comment thread
hdwhdw marked this conversation as resolved.
DIFF_COVER_COVERAGE_FILES: '$(Pipeline.Workspace)/coverage-integration/coverage.xml $(Pipeline.Workspace)/coverage-pure/coverage-pure.xml'

steps:
- checkout: self
clean: true
fetchDepth: 0

- download: current
artifact: coverage-pure

- download: current
artifact: coverage-integration

- stage: BuildAmd64
dependsOn: []
Expand Down
Loading