Fix CHASSIS_STATE_DB errors on non-chassis platforms#647
Open
rminnikanti wants to merge 2 commits intosonic-net:masterfrom
Open
Fix CHASSIS_STATE_DB errors on non-chassis platforms#647rminnikanti wants to merge 2 commits intosonic-net:masterfrom
rminnikanti wants to merge 2 commits intosonic-net:masterfrom
Conversation
Below error logs that appear across gnmi restarts: ERR gnmi#telemetry: :- getDbInfo: Failed to find CHASSIS_STATE_DB database in : key ERR gnmi#dialout_client_cli: :- getDbInfo: Failed to find CHASSIS_STATE_DB database in : key These logs cause teardown errors in sonic-mgmt tests Signed-off-by: Ravi Minnikanti <[email protected]>
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Ravi Minnikanti <[email protected]>
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #654
What I did
Fixed syslog errors across gnmi container restarts
How I did it
Added check to ensure DB present on the running DB config before attempting to access it. On non-chassis platforms (e.g. single-ASIC), the database container strips the chassis DB entries from database_config.json at startup. Attempting to connect without this guard causes libswsscommon to throw "Failed to find CHASSIS_STATE_DB database in : key" on every process start.
How to verify it
Run sonic-mgmt tests that does
config reloadand does log analyzer. Verified tests don't face teardown errors.