Revert "Add redis db alias for easy accessing redis db"#26889
Draft
xwjiang-ms wants to merge 1 commit intomasterfrom
Draft
Revert "Add redis db alias for easy accessing redis db"#26889xwjiang-ms wants to merge 1 commit intomasterfrom
xwjiang-ms wants to merge 1 commit intomasterfrom
Conversation
This reverts commit a246d1d.
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the previously added Redis DB alias generation (and its supporting Python helper) to address a platform test failure in platform_tests/counterpoll/test_counterpoll_watermark.py related to queue watermark/PG drop.
Changes:
- Removes the
sonic-db-aliases.pyhelper script used to derive DB ID/port fromSonicDBConfig. - Removes the
bash.bashrcstartup logic that generatedredis-*aliases via the helper script. - Removes the image build step that installed
sonic-db-aliases.pyinto/usr/local/bin.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
files/scripts/sonic-db-aliases.py |
Deleted the helper script that queried swsscommon.SonicDBConfig for DB ID/port. |
files/image_config/bash/bash.bashrc |
Deleted shell startup function that generated redis-* aliases at login. |
files/build_templates/sonic_debian_extension.j2 |
Removed installation/copy step for the deleted helper script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #25600 for platform_tests/counterpoll/test_counterpoll_watermark.py test_counterpoll_queue_watermark_pg_drop failure