Restart pmon in syncd.sh to clean up invalid fd#26864
Draft
ganglyu wants to merge 1 commit intosonic-net:masterfrom
Draft
Restart pmon in syncd.sh to clean up invalid fd#26864ganglyu wants to merge 1 commit intosonic-net:masterfrom
ganglyu wants to merge 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Geoffrey Lyu <[email protected]>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
pmon holds file descriptors that become invalid when syncd restarts, causing pmon to malfunction. Stopping pmon before syncd starts/stops ensures pmon always restarts with clean state after syncd is ready.
Work item tracking
How I did it
How to verify it
On a Mellanox device, perform a cold reboot and confirm:
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)