Fix/setup script compat#156
Closed
mrn55 wants to merge 2 commits into
Closed
Conversation
3 tasks
solomon2773
added a commit
that referenced
this pull request
May 7, 2026
…ore (#157) Fix New-HexSecret on PowerShell 7 — case-insensitive variable lookup made the $Bytes parameter and $bytes local collide, breaking secret generation. Rename the local to $secretBytes (and the parameter to $ByteCount with a back-compat -Bytes alias) so existing callers like `New-HexSecret -Bytes 24` keep working. Broaden the .env ignore rule to cover generated `.env.backup-*` files while explicitly allowlisting the three tracked templates (`.env.example`, `.env.test`, `e2e/.env.real.example`). Migrated from #156 by @mrn55. The PowerShell 7 version check from that PR was already merged separately. Co-authored-by: Neal <[email protected]> Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]>
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup.ps1so users fail fast instead of hitting Windows PowerShell 5 compatibility errors.$Bytes/$bytesvariable collision..envignore rules so generated.envbackups are not shown as untracked files, while keeping tracked env templates available.Validation
setup.ps1in PowerShell 7 through the Docker preflight and secret generation path..envand.env.backup-*are ignored while.env.example,.env.test, ande2e/.env.real.exampleremain trackable.Release And Docs Checklist
architecture.md) if this PR changes architecture, deployment topology, component responsibilities, or major data flow.Reviewed for release:marker inarchitecture.md.