refactor: rename defaultCamera/defaultRaycaster canvas props to camera/raycaster#48
Merged
Merged
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the
<Canvas>propsdefaultCameraanddefaultRaycastertocameraandraycaster.The default prefix was chosen to reflect how these props work internally: the canvas maintains a stack for both the active camera and raycaster, and these props seed the bottom of that stack — the fallback that's active unless something higher in the scene graph (e.g. a portal) pushes its own onto the stack.
While accurate, the default prefix turns out to be an implementation detail that leaks into the public API. From a user's perspective, camera and raycaster are simply "the camera/raycaster to use for this canvas" — the stack mechanism is invisible. The longer names also create friction for the common case where users just want to supply a custom camera without thinking about stacks at all.
Changes
Breaking change
This is a rename-only breaking change. No behavior is altered. Users on the previous API need to rename their props.