upgrade: memo and destructure packages upgrade for Solid 2.0#890
Draft
davedbase wants to merge 2 commits into
Draft
upgrade: memo and destructure packages upgrade for Solid 2.0#890davedbase wants to merge 2 commits into
davedbase wants to merge 2 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@solid-primitives/memo`:
createDebouncedMemo/createThrottledMemosections: changed from "deprecated" to "Removed in v2", linking to@solid-primitives/schedulewith a note that it isn't yet updated for Solid 2.0createAsyncMemosection: "Removed in v2", explaining thatcreateResourceno longer exists and pointing to the Solid 2.0 alternativescreateLazyMemo"Not ownerless" section: replaced with "Auto-disposal and recomputation" — the v2 nativecreateMemo({ lazy: true })behavior, including the note thatprevresets toundefinedafter a full unsubscribe/resubscribe cycleequals" section: tightened the prose to match the v2 pull-based rationaleThis completes the deprecation of create of previously primitives but I'm questioning if they should probably be brought back. Looking for suggestion and confirmation that this is indeed the correct path foward.
@solid-primitives/destructure:pnpminstall line (was missing)name,equals) that were previously inherited implicitly from `MemoOptions