Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .changeset/lifecycle-solid2-migration.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
---
"@solid-primitives/lifecycle": major
---

Migrate to Solid.js v2.0 (beta.10)

## Breaking Changes

**Peer dependencies**: `solid-js@^2.0.0-beta.10` and `@solidjs/web@^2.0.0-beta.10` are now required.

- `isServer` is now imported from `@solidjs/web` (was `solid-js/web`)
- `onMount` replaced with `onSettled` — `createIsMounted` now schedules its signal update after the owner settles
- `getListener` replaced with `getObserver` — `isHydrated` uses `getObserver` to detect reactive context
- `sharedConfig.context` replaced with `sharedConfig.hydrating` — `isHydrated` now reads the boolean `hydrating` flag
- `renderToString` in server tests now imported from `@solidjs/web` (was `solid-js/web`)

No changes to the public API: `createIsMounted`, `isHydrated`, and `onElementConnect` signatures are unchanged.
6 changes: 4 additions & 2 deletions packages/lifecycle/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,11 @@
"test:ssr": "pnpm run vitest --mode ssr"
},
"peerDependencies": {
"solid-js": "^1.6.12"
"@solidjs/web": "^2.0.0-beta.10",
"solid-js": "^2.0.0-beta.10"
},
"devDependencies": {
"solid-js": "^1.9.7"
"@solidjs/web": "2.0.0-beta.10",
"solid-js": "2.0.0-beta.10"
}
}
10 changes: 5 additions & 5 deletions packages/lifecycle/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import {
type Accessor,
createSignal,
getListener,
getObserver,
onCleanup,
onMount,
onSettled,
sharedConfig,
} from "solid-js";
import { isServer } from "solid-js/web";
import { isServer } from "@solidjs/web";

/**
* @returns a signal accessor that will return a `false` initially,
Expand All @@ -23,7 +23,7 @@ import { isServer } from "solid-js/web";
export function createIsMounted(): Accessor<boolean> {
if (isServer) return () => false;
const [isMounted, setIsMounted] = createSignal(false);
onMount(() => setIsMounted(true));
onSettled(() => { setIsMounted(true); });
return isMounted;
}

Expand All @@ -39,7 +39,7 @@ export function createIsMounted(): Accessor<boolean> {
* @see https://github.com/solidjs-community/solid-primitives/tree/main/packages/lifecycle#isHydrated
*/
export const isHydrated = (): boolean =>
!isServer && (!sharedConfig.context || (!!getListener() && createIsMounted()()));
!isServer && (!sharedConfig.hydrating || (!!getObserver() && createIsMounted()()));

/**
* Calls the {@link fn} callback when the {@link el} is connected to the DOM.
Expand Down
17 changes: 8 additions & 9 deletions packages/lifecycle/test/index.test.ts
Original file line number Diff line number Diff line change
@@ -1,20 +1,19 @@
import { describe, test, expect } from "vitest";
import { createEffect, createRoot } from "solid-js";
import { createRoot, flush } from "solid-js";
import { createIsMounted, isHydrated } from "../src/index.js";

describe("createIsMounted", () => {
test("createIsMounted", () => {
createRoot(dispose => {
const isMounted = createIsMounted();
let isMounted!: () => boolean;
const dispose = createRoot(d => {
isMounted = createIsMounted();
expect(isMounted()).toBe(false);

createEffect(() => {
expect(isMounted()).toBe(true);
dispose();
});
return d;
});

expect(createIsMounted()()).toBe(true);
flush();
expect(isMounted()).toBe(true);
dispose();
});
});

Expand Down
2 changes: 1 addition & 1 deletion packages/lifecycle/test/server.test.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { describe, test, expect } from "vitest";
import { createRoot } from "solid-js";
import { createIsMounted, isHydrated } from "../src/index.js";
import { renderToString } from "solid-js/web";
import { renderToString } from "@solidjs/web";

describe("createIsMounted", () => {
test("createIsMounted", () => {
Expand Down
7 changes: 5 additions & 2 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.