This repository was archived by the owner on Jun 27, 2019. It is now read-only.
Open
Conversation
It support to declare them on conffiles like:
{
"name": "NodeName",
"options": {
...
},
"type": "fbp:FILE_NAME.fbp"
}
Support was added only on runner (no generator support yet).
It leaks parsers (and consequently node types).
Paths used to look for fbp files are passed by runner.
Signed-off-by: Bruno Dilly <[email protected]>
|
Just don't abuse "type" and then an encoded string. JSON is structured, so add a new key with an object instructing the mets type and all |
Contributor
|
Should we support composed as well? |
|
Composed is a meta, so we're good if we support them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more like a WIP since it's leaking parsers
and I intent to re-write it following an approach
discussed with @ibriano yesterday.
Parsers would have a way to call back its users
to handle with unknown types (or metatypes).
So runner would handle node types declared on conf files
just like it would with ones declared on fbp files.
I'm pushing it here to see if anybody else would like
to comment on that before doing such change.
flow: support fbp meta types on conffiles
It support to declare them on conffiles like:
{
"name": "NodeName",
"options": {
...
},
"type": "fbp:FILE_NAME.fbp"
}
Support was added only on runner (no generator support yet).
It leaks parsers (and consequently node types).
Paths used to look for fbp files are passed by runner.
Signed-off-by: Bruno Dilly [email protected]