Skip to content
This repository was archived by the owner on Jun 27, 2019. It is now read-only.

fbp meta types on conf files#927

Open
bdilly wants to merge 1 commit intosolettaproject:masterfrom
bdilly:conf_declare_v1
Open

fbp meta types on conf files#927
bdilly wants to merge 1 commit intosolettaproject:masterfrom
bdilly:conf_declare_v1

Conversation

@bdilly
Copy link
Contributor

@bdilly bdilly commented Oct 21, 2015

This is more like a WIP since it's leaking parsers
and I intent to re-write it following an approach
discussed with @ibriano yesterday.

Parsers would have a way to call back its users
to handle with unknown types (or metatypes).

So runner would handle node types declared on conf files
just like it would with ones declared on fbp files.

I'm pushing it here to see if anybody else would like
to comment on that before doing such change.

flow: support fbp meta types on conffiles

It support to declare them on conffiles like:

{
"name": "NodeName",
"options": {
...
},
"type": "fbp:FILE_NAME.fbp"
}

Support was added only on runner (no generator support yet).
It leaks parsers (and consequently node types).

Paths used to look for fbp files are passed by runner.

Signed-off-by: Bruno Dilly [email protected]

It support to declare them on conffiles like:

{
   "name": "NodeName",
   "options": {
       ...
   },
   "type": "fbp:FILE_NAME.fbp"
}

Support was added only on runner (no generator support yet).
It leaks parsers (and consequently node types).

Paths used to look for fbp files are passed by runner.

Signed-off-by: Bruno Dilly <[email protected]>
@barbieri
Copy link

Just don't abuse "type" and then an encoded string. JSON is structured, so add a new key with an object instructing the mets type and all

@cabelitos
Copy link
Contributor

Should we support composed as well?

@barbieri
Copy link

Composed is a meta, so we're good if we support them

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants