Refactor ServerRunner to use Resource, fix unsafe .allocated cases#4267
Merged
Conversation
ivan-klass
force-pushed
the
proper-cats-resources
branch
2 times, most recently
from
58201b8 to
84ea3d5
Compare
ivan-klass
force-pushed
the
proper-cats-resources
branch
from
5ce6acd to
d326dc4
Compare
ivan-klass
force-pushed
the
proper-cats-resources
branch
from
d326dc4 to
2044178
Compare
ivan-klass
changed the title
Member
|
Great changes, thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ServerRunnerinterface was refactored to provide more idiomaticResource[IO, Unit]rather than unsafeIO[IO[Unit]].The Cats-based test server now also provides a properly scoped server resource instead of unfair wrap
Resource.eval(underlyingResource.allocated.map(_._2)). The previous approach was leaky — imagineNow, the resource is guaranteed to be released at the end of the test, regardless of whether it was released within the test scope or not.