feat(performance): add configuration settings for concurrency and tim…#41
Merged
softberries merged 4 commits intomainfrom Jan 30, 2026
Merged
Conversation
…eouts on large clusters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds performance tuning configuration for monitoring large Kafka clusters with many consumer groups and partitions. It introduces parallel fetching of watermarks and group offsets to reduce collection times, controlled by configurable concurrency limits and timeouts.
Changes:
- Added
PerformanceConfigwith settings for Kafka operation timeouts, offset fetch timeout, and maximum concurrent operations for groups and watermarks - Implemented parallel watermark and offset fetching methods with semaphore-based concurrency control
- Updated documentation with guidance for tuning performance on large clusters
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/config.rs | Added PerformanceConfig struct with timeout and concurrency settings, including defaults and tests |
| src/kafka/client.rs | Added parallel watermark fetching method and updated client to accept performance config |
| src/collector/offset_collector.rs | Added parallel offset collection method with bounded concurrency for consumer groups |
| src/cluster/manager.rs | Integrated performance config and fixed semaphore usage for timestamp fetching |
| README.md | Added comprehensive documentation on performance tuning for large clusters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eouts on large clusters