Chore: Also list native files with clang-tidy on android#9164
Open
wisniewskij wants to merge 4 commits intomainfrom
Open
Chore: Also list native files with clang-tidy on android#9164wisniewskij wants to merge 4 commits intomainfrom
wisniewskij wants to merge 4 commits intomainfrom
Conversation
tjzel
reviewed
Mar 23, 2026
| "lint:js": "eslint src __tests__ __typetests__ && yarn prettier --check src __tests__ __typetests__", | ||
| "lint:android": "../../scripts/validate-android.sh && ./android/gradlew -p android spotlessCheck -q && ../../scripts/cpplint.sh android/src && yarn format:android:cpp --dry-run -Werror && yarn lint:cmake", | ||
| "lint:common": "../../scripts/validate-common.sh && ../../scripts/cpplint.sh Common && yarn format:common --dry-run -Werror", | ||
| "lint:clang-tidy": "../../scripts/clang-tidy-lint.sh \"Common\"", |
Collaborator
There was a problem hiding this comment.
This will lint both android and apple files during a single run and we don't want that as compile_commands.json are only per single platform - this should be split into several commands.
Collaborator
There was a problem hiding this comment.
Also, please make lint-clang-tidy GitHub action triggerable by workflow_dispatch so we could manually dispatch the action to test this PR.
Contributor
Author
There was a problem hiding this comment.
I'm pretty sure that's not the case since run-clang-tidy lints strictly only files that are in the compilation database, which is generated per given platform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously we would lint only files in "Common" with clang-tidy.
After this PR we also lint native files for android.
Test plan