[SET] Migrate SET examples to SETBoundary#9132
Open
bartlomiejbloniarz wants to merge 7 commits into@bartlomiejbloniarz/set-boundary-2from
Open
[SET] Migrate SET examples to SETBoundary#9132bartlomiejbloniarz wants to merge 7 commits into@bartlomiejbloniarz/set-boundary-2from
bartlomiejbloniarz wants to merge 7 commits into@bartlomiejbloniarz/set-boundary-2from
Conversation
This updates React Navigation with fixes to `useIsFocused` behavior to avoid workarounds for SET. It also disables `detachInactiveScreens`, which seems to conflict with SETs. Note that it'll be removed in React Navigation 8, so this is temporary. https://github.com/user-attachments/assets/e1ba5aca-1fe2-44c3-9a50-7088079c0da2 --------- Co-authored-by: Bartłomiej Błoniarz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates all the examples to use the
SharedTrasntionBoundaryusing thewithSharedTransitionBoundaryhelper that handles screen focus withuseIsFocused.Test plan
Check if the examples work :)