feat: C++ layer for CSS animation events support#9097
Open
Conversation
MatiPl01
force-pushed
the
@matipl01/css-animation-event-callbacks
branch
from
2dc43d9 to
e405031
Compare
MatiPl01
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the first one of the CSS animation/transition callbacks support series. It adds the base logic responsible for detecting which event to emit and when in CSS animations, adds a
CSSEventsEmitterclass responsible for emitting a batch of events from the lastperformOperationscall and other necessary changes necessary to get durations/timings from the animation object.I decided to support:
onAnimationStart,onAnimationEndandonAnimationIterationevents for now (I don't supportonAnimationCancelyet as it doesn't seem to be much useful - animation is cancelled only when removed from the style object so the user already knows when it should be cancelled - maybe we will add support for this one later on).Test plan
Build the app, see that it compiles and pre-existing CSS animations aren't broken.