Open
Conversation
mat-hek
reviewed
Dec 19, 2025
Contributor
mat-hek
left a comment
mat-hek
left a comment
There was a problem hiding this comment.
Looks good, left mostly stylistic suggestions
| It allows to store, update and render the assigns similarly to Phoenix LiveView. | ||
| ## Architecture | ||
| ### Popcorn part | ||
| Local Live View is running on AtomVM in WASM in the browser using erlang virtual machine. |
Contributor
There was a problem hiding this comment.
this sounds weird, AtomVM is an erlang virtual machine
Comment on lines
3
to
5
| ## What is a LocalLiveView? | ||
| LocalLiveView is a project that aims to store the LiveView state in the browser in a virtual machine provided by Popcorn. | ||
| It allows to store, update and render the assigns similarly to Phoenix LiveView. |
Contributor
There was a problem hiding this comment.
Let's remove this and move the file introduction/welcome.md -> architecture.md
| It is built as an elixir project with supervisor tree. | ||
|
|
||
|  | ||
| - LocalLiveView.Application starts LocalLiveView.Dispatcher and LocalLiveView.Server.Supervisor. |
Contributor
There was a problem hiding this comment.
let's put the module names in backticks
Co-authored-by: Mateusz Front <[email protected]>
Co-authored-by: Mateusz Front <[email protected]>
Co-authored-by: Mateusz Front <[email protected]>
Co-authored-by: Mateusz Front <[email protected]>
Co-authored-by: Mateusz Front <[email protected]>
Co-authored-by: Mateusz Front <[email protected]>
Co-authored-by: Mateusz Front <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added technical description on the architecure of LocalLiveView.