fix(eslint-plugin): eslint rules not found

[michaelbe812]

From what I have seen the issue #225 is caused by an incorrect file pattern which was introduced in commit #837d792

Fixes #225

[weberhofer]

Unbelieveable: I have checked that line before but didn't see the issue.
Following my tests, the line must be like that:

files: ['**/*.ts', '**/*.js'],

[michaelbe812]

Oh yes, you're right. I will update my PR :)

[rainerhahnekamp]

@weberhofer @michaelbe812, Thanks again. I am currently on holiday and have therefore limited availability (I can still publish the lib).

My primary concern is the following: We have so many integration tests, but why did none of them fail? If our tests failed this case completely, we should probably also add one.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[michaelbe812]

@weberhofer @michaelbe812, Thanks again. I am currently on holiday and have therefore limited availability (I can still publish the lib).

My primary concern is the following: We have so many integration tests, but why did none of them fail? If our tests failed this case completely, we should probably also add one.

This is also what I am wondering about. Somehow I have the feeling that something's wrong with the integration tests. I'll try to check

[weberhofer]

I think the old file definitions worked on older eslint versions. My configurations broke after eslint 9.30.1. Integration tests seem to use eslint 8.x versions.

[rainerhahnekamp]

@michaelbe812, I'd like to push two new integration tests to your branch. One will run nx-create-workspace and apply our eslint rules via a simple script. The other one does the same for the Angular CLI. In that way, we would be notified if nx or angular-eslint/schematics changes their layout.

[michaelbe812]

@michaelbe812, I'd like to push two new integration tests to your branch. One will run nx-create-workspace and apply our eslint rules via a simple script. The other one does the same for the Angular CLI. In that way, we would be notified if nx or angular-eslint/schematics changes their layout.

Great idea 💡 this will definitely add some more safety nets.

I'm just asking myself if it would not be enough to just scaffold minimal projects with each eslint version which should be supported instead of full-blown nx and angular workspaces?

[rainerhahnekamp]

So it should only be the minimal angular app that no and cli generate. Not the full blown ones we already have.

but I think it is important to verify if someone runs a new ng new that sheriff works as expected.

[rainerhahnekamp]

Since I haven't been able to come up with the integration tests and we have a blocker here, I merged the fix and published.

Integration tests will be done in a separate, follow-up issue.

Thanks @michaelbe812 and @weberhofer for fixing this.