[Helper] Messaging: add msg_*_once macros to display a message only once per component instance#6164
Open
fredroy wants to merge 1 commit into
Open
[Helper] Messaging: add msg_*_once macros to display a message only once per component instance#6164fredroy wants to merge 1 commit into
fredroy wants to merge 1 commit into
Conversation
3de5a26 to
fd13f5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of code throw message in often-called functions such as draw() or update() or in loops.
and often, a boilerplate code like
is used, like for example in #6152 , when you want to warn the user once in the draw method, but dont want to spam.
So I asked Claude to implement a msg_*_once function to display only once per component (this part of code is quite... special)
The only small flaw is that the OnceTracker is thread-local so If emitted from different threads it will be displayed more than once. But the other alternative was a std::mutex (his first version) so it could introduce uncessary locks IMO
I flagged experimental because the Messaging part is a bit complex...
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if