Skip to content

[FEM] TetrahedralCorotationalFEMForceField fix stream functions#6128

Merged
fredroy merged 2 commits into
sofa-framework:masterfrom
Lucas-TJ:TetrahedralCorotationalFEMForceField_fix_stream_functions
Jun 29, 2026
Merged

[FEM] TetrahedralCorotationalFEMForceField fix stream functions#6128
fredroy merged 2 commits into
sofa-framework:masterfrom
Lucas-TJ:TetrahedralCorotationalFEMForceField_fix_stream_functions

Conversation

@Lucas-TJ

@Lucas-TJ Lucas-TJ commented May 27, 2026

Copy link
Copy Markdown
Contributor

Hello !

For my project, I want to save and load data from components. In TetrahedralCorotationalFEMForceField, I had a problem with the data " tetrahedronInfo" : this data contained no value, but this is necessary to load correctly.

So, in this PR, I fix the Output stream and Input stream functions from TetrahedralCorotationalFEMForceField.

For example,
Without this PR :
Screenshot from 2026-05-27 14-41-27

With this PR :
Screenshot from 2026-05-27 14-41-20

Now, I can save and load the component TetrahedralCorotationalFEMForceField.

Thank you !

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels May 27, 2026
@fredroy

fredroy commented May 27, 2026

Copy link
Copy Markdown
Contributor

[ci-build][with-all-tests]

@alxbilger

Copy link
Copy Markdown
Contributor

Could you add a test checking that you can read something that you saved, and that it matches?

@Lucas-TJ

Lucas-TJ commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

Could you add a test checking that you can read something that you saved, and that it matches?

Ok ! I can do it !

@bakpaul bakpaul added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Jun 4, 2026
@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Jun 18, 2026
@fredroy fredroy force-pushed the TetrahedralCorotationalFEMForceField_fix_stream_functions branch from 7900c71 to 71c700e Compare June 29, 2026 05:58
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jun 29, 2026
@fredroy fredroy merged commit d303889 into sofa-framework:master Jun 29, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants