SNOW-2688693: fixed on_error parameter passing in write_pandas#2671
Draft
krispharper wants to merge 1 commit intosnowflakedb:mainfrom
Draft
SNOW-2688693: fixed on_error parameter passing in write_pandas#2671krispharper wants to merge 1 commit intosnowflakedb:mainfrom
krispharper wants to merge 1 commit intosnowflakedb:mainfrom
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
f236c76 to
155f118
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes The write_pandas function returns
invalid value [?] for parameter 'ON_ERROR'instead of actual errors SNOW-2688693 SNOW-3068156 #2638.Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Previously, the
on_errorparameter to theCOPY INTOstatement inwrite_pandaswas passed via qmark style parameters. If there is an error in theCOPY INTOcommand, instead of the actual error returning to the caller, we getinvalid value [?] for parameter 'ON_ERROR'. I.e., there is an error passing the parameter to the statement.All other parameters except for table name are passed in via string interpolation, and this PR changes the
on_errorparameter to be passed via string interpolation as well. After this change, the actual underlying error is passed back to the caller.(Optional) PR for stored-proc connector: