feat(step-certificates): add custom labels support to service resource#245
Open
jalet wants to merge 3 commits intosmallstep:masterfrom
Open
feat(step-certificates): add custom labels support to service resource#245jalet wants to merge 3 commits intosmallstep:masterfrom
jalet wants to merge 3 commits intosmallstep:masterfrom
Conversation
Add service.labels configuration option to allow users to add custom labels to the Kubernetes Service resource. This enables integration with service meshes, monitoring systems, and compliance tagging frameworks (NIS2, GDPR). Custom labels are merged with standard Helm labels and follow the existing pattern established by serviceaccount.labels. - Add service.labels configuration in values.yaml - Update Service template to render custom labels - Document feature in README with examples
|
|
github-actions
bot
added
the
needs triage
|
This PR is really helpful. Maybe have even a global labels configuration to add labels to all resources and then have specified labels to add additional to e.g. service resource. |
Extend custom label support beyond the service resource to every Kubernetes resource in the chart: pods (bootstrap, CA), RBAC (Role, RoleBinding, ClusterRole, ClusterRoleBinding), and all Secret resources. Also refactors rbac.yaml to use the step-certificates.labels helper instead of duplicating label fields, and adds global.labels to the helpers template so the labels propagate automatically. Closes the gap left by the previous commit which only covered the service resource.
Author
This should be fixed no, there's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
global.labelssupport to propagate custom labels to all chart resources, andservice.labelsfor service-specific custom labels.global.labels: applied to all resources (Deployment, StatefulSet, Service, ServiceAccount, etc.)service.labels: applied only to the Service resourceserviceaccount.labels