Fix cd command parsing for quotes and empty arguments#322
Merged
sloria merged 2 commits intosloria:mainfrom Feb 16, 2026
Merged
Fix cd command parsing for quotes and empty arguments#322sloria merged 2 commits intosloria:mainfrom
cd command parsing for quotes and empty arguments#322sloria merged 2 commits intosloria:mainfrom
Conversation
- Replace naive `cmd.split()[1]` with `shlex` parsed arguments to correctly handle directory names containing spaces (e.g., `cd "test dir"`) - Add check for argument length to support the bare `cd` command; defaults to HOME (`~`) instead of raising an `IndexError` - Add regression test `test_cd_spaces` and corresponding session file
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues with the internal
cdcommand implementation in the interactive player:run_commandusedcmd.split()[1]to extract the directory argument. This failed for paths with spaces (e.g.,cd "my dir") becausesplit()would break the quoted string into multiple parts.cdcommand: Runningcdwithout arguments caused anIndexErrorbecause the code blindly accessed index1.Changes:
src/doitlive/keyboard.py: Updatedrun_commandto utilize thecommand_as_list(parsed byshlex) instead of manual splitting.src/doitlive/keyboard.py: Added logic to default to~(HOME) if no directory argument is provided, mirroring standard shell behavior.test_cd_spacesand a session filetests/sessions/cd_spaces.sessionto verify that directories with spaces are handled correctly.