Open
Conversation
|
Hi, Edit: I imade a PR to fix the compile error mariomka#1 Original post: I was trying to install your fork following this instruction However, I failed to install it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Bundler can't work with Rust 2018 edition code because
rustfmtdoesn't understand new syntax. Related issue: #6To solve this it's necessary to use new
rustfmt-nightly, there are two options:CFG_RELEASE_CHANNEL=nightly;CFG_RELEASE=nightlyrustup component add rustfmtThen, I opted for adding a feature
inner_rustfmtto select the desired option, it calls the CLI by default. (Based on https://github.com/hatoo/cargo-snippet/blob/master/src/writer.rs)Also, I've updated the project to the 2018 edition and dependencies to the newest versions.
By last, I found a syntax that doesn't work properly. But I'm not sure how to fix it.
Taking a modified version of
main.rsfile from "complicated" test input:It bundles as:
self::my_libis not replaced byself::.But it works properly if syntax
self::{lib_name}isn't used: