pvacms: bind --cert_validity-server and -ioc to their own config fields - #53
Open
george-mcintyre wants to merge 1 commit into
Open
pvacms: bind --cert_validity-server and -ioc to their own config fields#53george-mcintyre wants to merge 1 commit into
george-mcintyre wants to merge 1 commit into
Conversation
… fields All three per-type options bound to default_client_cert_validity, so the last one parsed clobbered the client validity and the server/IOC validities silently kept their defaults. Env parsing and consumers were already per-type. Closes #48
|
Verified the fix on commit fa3a0aa from branch bin/rhel9-x86_64/pvacms -V I rebuilt PVXS-CMS and reran the original regression test using separate validity values: --cert_validity-client 91d
--cert_validity-server 92d
--cert_validity-ioc 93dThe effective configuration now reports the expected values: The original option-binding issue is resolved. I am satisfied with the fix from a regression-testing standpoint. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48. All three per-type validity options bound to
default_client_cert_validity(copy-paste), so the last one parsed clobbered the client validity and server/IOC kept defaults. Environment-variable parsing and all consumers were already per-type; the fix is the two bindings.Verified:
pvacms -v --cert_validity-client 1M --cert_validity-server 2M --cert_validity-ioc 3Mnow reports 1M/2M/3M in the effective config; generic--cert_validity 9Mstill sets all three.