Fix controller install when container was removed manually - #104
Open
AryanP123 wants to merge 1 commit into
Open
Fix controller install when container was removed manually#104AryanP123 wants to merge 1 commit into
AryanP123 wants to merge 1 commit into
Conversation
fgiorgetti
reviewed
Jun 16, 2026
| self.module.debug("skupper-controller service exists but container is missing") | ||
| self.create_container() | ||
| self.start_service() | ||
| return True |
Member
There was a problem hiding this comment.
It assumes that the existing service that was left behing is still valid.
I'd recommend calling just module_utils.system.delete_service() and let rest of the updated method runs, instead of returning.
Fixes skupperproject#96 Signed-off-by: Aryan Puttur <putturaryan@gmail.com>
AryanP123
force-pushed
the
fix-controller-recreate-after-rm
branch
from
June 17, 2026 14:16
4a991c9 to
659fee8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96
skupper.v2.controllerinstallnow recreates the container when the systemd service exists but the container was removed (e.g.podman rm -f).Skips install only when the container is already present
Added unit test coverage for the service-exists / container-missing case