Fix several recent issues from transformers, pandas, gpytorch#1134
Merged
BenjaminBossan merged 7 commits intomasterfrom Feb 25, 2026
Merged
Conversation
- Some numerical differences from T5 - Tokenizer repr has changed
I had a different error message locally because pyarrow was installed -__-
Pandas 3 is not available for Python 3.10, so change the error message back in that case.
thomasjpfan
reviewed
Feb 23, 2026
skorch/tests/test_helper.py
Outdated
| df = df.assign(invalid=data) | ||
| if pandas_ge3: | ||
| msg = ( | ||
| r"Cannot interpret '<StringDtype\(" |
Member
There was a problem hiding this comment.
This error message is less obvious about what is wrong compared to "The following columns have dtypes that cannot be interpreted as"`. Is there a way to keep the original error message?
Collaborator
Author
There was a problem hiding this comment.
That was a great suggestion, done.
Allows to mostly revert the pandas tests.
thomasjpfan
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reprof tokenizer instances changed.hasattr(model, 'get_encoder')is no longer a reliable way to identify encoder-decoder models. Usingmodel.config.is_encoder_decodernow. I checked that the attribute exists in transformers v4.37.2 (release 2 years ago) and it's there, so this should be a safe change.