Add multiple new icons#476
Open
paulober wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip Pull Request Checklist:
swift testUsed Claude Code to identify that the missing icons were on the classpath
via material-icons-extended but not wired into composeSymbolName/
composeImageVector.
Summary
Adds 5 SF-Symbol-name mappings that were missing from the curated Android
icon table in
Image.swift. All backed bymaterial-icons-extended, whichis already an
api()dependency of this module — the classes were simplynever added to the curated symbol-name switch.
bookmark/bookmark.fill->Icons.Outlined.BookmarkBorder/Icons.Filled.Bookmarkperson.text.rectangle/barcode->Icons.Outlined.Badgecamera.viewfinder->Icons.Outlined.QrCodeScannerbarcode.viewfinder->Icons.Outlined.CropFreechart.bar.xaxis->Icons.Outlined.BarChartAndroid-only:
composeSymbolName/composeImageVectorlive entirely insidethe transpile-mode
#if SKIPblock, never compiled for iOS/macOS — thiscannot affect Apple platforms.