Skip to content

Run each async udf in its own thread#124

Open
nkitsaini wants to merge 18 commits into
mainfrom
users/asaini/event-loop-worker
Open

Run each async udf in its own thread#124
nkitsaini wants to merge 18 commits into
mainfrom
users/asaini/event-loop-worker

Conversation

@nkitsaini

@nkitsaini nkitsaini commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Note

Medium Risk
Touches core external-function request scheduling, concurrency, and cancellation paths; misbehavior could affect timeouts, client disconnects, or async UDF stability under load.

Overview
Async UDF execution no longer runs inline on the ASGI request loop (or via a per-call asyncio.run in a thread for async paths). Async invocations are scheduled on a process-wide dedicated event-loop thread via _dispatch_to_async_loop and _cancellable_run, so loop-bound clients (e.g. httpx) can be reused and concurrent async calls are not serialized. Sync UDFs are explicitly routed through to_thread + asyncio.run so they cannot block that shared loop.

Cancellation is reworked: cancel_event is set when the function task is still pending after the first-completed wait, and always in finally, instead of only on disconnect/timeout paths—so off-thread work actually sees the signal.

Managed UDF server (run_udf_app) sets Uvicorn timeout_keep_alive from SINGLESTOREDB_UDF_KEEPALIVE_TIMEOUT (default 120 seconds) to reduce aggressive idle connection closes under load.

Adds test_udf_event_loop.py covering cancellable runs, dispatch concurrency, resource reuse, and Application routing (async on dispatch thread vs sync on a worker).

Reviewed by Cursor Bugbot for commit 0a7a0a9. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread singlestoredb/functions/ext/asgi.py
Comment thread .github/workflows/publish.yml Outdated
Comment thread singlestoredb/functions/ext/asgi.py Outdated
@nkitsaini nkitsaini force-pushed the users/asaini/event-loop-worker branch from 2f24109 to 53e6c9a Compare June 3, 2026 17:01
@nkitsaini nkitsaini force-pushed the users/asaini/event-loop-worker branch from 53e6c9a to 78a96f8 Compare June 3, 2026 18:20
Comment thread .github/workflows/publish.yml Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 018db7a. Configure here.

Comment thread singlestoredb/functions/ext/asgi.py
Comment thread singlestoredb/ai/embeddings.py Outdated
nkitsaini and others added 13 commits June 15, 2026 17:50
Async UDFs were running directly in uvicorn's event loop via
asyncio.create_task, competing with connection handling under heavy
concurrent load. This caused unresponsiveness when running from Jupyter
notebooks where the event loop is shared.

The fix introduces a dedicated event loop in a background thread for
async UDF execution. Coroutines are submitted via
run_coroutine_threadsafe() and awaited from the server loop, isolating
UDF work from HTTP I/O while preserving cooperative async scheduling
between UDFs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Cancel the concurrent.futures.Future in the UDF loop on
disconnect/timeout so the coroutine is interrupted promptly,
not just at the next cancel_on_event row check.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ture

asyncio.create_task() requires a coroutine but asyncio.wrap_future()
returns a Future. Use asyncio.ensure_future() which accepts both.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Prevents UDF event loop thread leaks when run_udf_app() is called
repeatedly in Jupyter notebooks.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Cancel udf_future when func_task is in pending set after asyncio.wait
- Cancel udf_future in finally block to ensure cleanup on any exit path
- Wrap post-construction code in try/except to call app.shutdown() if
  validation, config, or registration fails after Application is created

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Move udf_future initialization before input_handler['load']() to
  prevent NameError in finally block if parsing raises
- Lazily create UDF event loop on first async UDF invocation instead
  of unconditionally in __init__, avoiding wasted resources for
  sync-only or metadata-only usage
- Guard shutdown() against None loop/thread

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
After stopping the event loop and joining the thread, set both
_udf_loop and _udf_thread back to None so that _get_udf_loop()
can safely recreate them if called after shutdown.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The dedicated shared event loop still caused starvation under concurrent
async UDF calls. Switch to the same model used by sync UDFs: each request
gets its own thread with asyncio.run(), eliminating loop contention.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Wraps the inner coroutine in _cancellable_run which polls cancel_event
and raises CancelledError at the next await (~100ms), ensuring vector
UDFs respect disconnect/timeout signals without waiting for completion.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace asyncio.run() with _run_with_graceful_shutdown() that drains
pending callbacks before closing the loop, preventing RuntimeError from
httpx/anyio TLS cleanup in async UDFs calling OpenAI/LangChain APIs.

Add 17 unit tests covering graceful shutdown, cancellation timing,
exception propagation, context variable isolation, and concurrent safety.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@nkitsaini nkitsaini force-pushed the users/asaini/event-loop-worker branch from 018db7a to 1669fb2 Compare June 15, 2026 16:04
@nkitsaini nkitsaini force-pushed the users/asaini/event-loop-worker branch from 1669fb2 to 0a7a0a9 Compare June 15, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants