Conversation
cba3b7c to
1dddbff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for custom inline embeds (mentions, hashtags, etc.) to declare their character length for the platform keyboard, fixing
TextCapitalization.sentencesand word/sentence boundary detectionaround embeds.
Problem: All embeds are sent to the platform as a single
\uFFFCcharacter. The OS keyboard cannot detect sentence endings (e.g.@JohnDoe. Next sentence) because it only sees\uFFFC.--> notenough context for capitalization or word boundaries.
Solution:
int get lengthproperty toEmbedBuilder(defaults to1, fully backward compatible)OffsetMappinglayer at the platform text-input boundary that translates between document offsets (embeds = length 1) and expanded-text offsets (embeds =toPlainText().length)Usage: Override
toPlainText()andlengthon yourEmbedBuilder: