perf: make priority dequeue 240% faster#244
Merged
Merged
Conversation
Contributor
Author
|
@sindresorhus Hello! Let me know if something is unclear in this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
PriorityQueue#dequeue()Array#shift()with a head cursor and lazy compaction.This avoids repeatedly moving remaining array entries on every dequeue while preserving queue behavior.
The previous
shift()implementation also passes the new behavior tests; the tests verify behavior preservation, while the benchmarks show the performance gain.Benchmarks
Node.js v20.19.5
large-fifo-backlogpriority-queue-dequeue