[Hunter] further beta implementations #10738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buff trigger moved to a dedicated trigger_natures_ally_3 routine to avoid duplication, not sure on standards for this so happy to split it back out if needed
attack speed formula changed - please double check for accuracy e.g: (1 / 1.3) becomes (1 * 0.7) now
entirely passive and spelldata parsed now
was this always bugged?
I will do thorough testing of rolling periodic stuff down the line, trying to get more impls in place atm
- WRQ + Critical Precision interaction - benefit tracking for Focus Fire & default value
- Base class created for Black Arrow - Deathblow cost override fixed
ZingusWoW
force-pushed
the
beta-implementations
branch
from
b50bf44 to
cf2a145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.