Several smaller bugfixes #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnouri
force-pushed
the
bugfix/tz-and-others
branch
2 times, most recently
from
e8e2584 to
129f1bb
Compare
- pd.Timedelta does not like to be initialized with `tz` argument, failing with "Cannot pass a datetime or Timestamp with tzinfo with the tz parameter. Use tz_convert instead." My understanding is that since all timezones are UTC throughout, it should be safe to drop this everywhere. - flph.fuzzylabels returns a list for me, and so I explicitly convert it to an np.array before applying fancy indexing with `labels[pts] = 'GND'`. Before, this would error with "list indices must be integers or slices, not tuple". - The existing glob pattern did not seem to work for the new way of saving pickles into subdirectories of `outdir`. Instead I'm now applying to separate glob patterns that will pick up pkl files from the `INDATA/` directory and its subdirectories. - I'm creating the output directories for plots and data if they do not exist already. - The plotting functions mysteriously saw a `GN` label. I'm really not sure if this is the right thing to do here, but I simply assumed that this was the same as `GND` and added another entry to the colormap accordingly. This may be really a symptom of a bug that should be fixed in another place. - In proc_fl, set `odir_np` also when do_save==False, because it's used later on.
dnouri
force-pushed
the
bugfix/tz-and-others
branch
from
129f1bb to
2a14767
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pd.Timedelta does not like to be initialized with
tzargument,failing with "Cannot pass a datetime or Timestamp with tzinfo with the
tz parameter. Use tz_convert instead." My understanding is that since
all timezones are UTC throughout, it should be safe to drop this
everywhere.
flph.fuzzylabels returns a list for me, and so I explicitly convert
it to an np.array before applying fancy indexing with
labels[pts] = 'GND'. Before, this would error with "list indices must be integersor slices, not tuple".
The existing glob pattern did not seem to work for the new way of
saving pickles into subdirectories of
outdir. Instead I'm nowapplying to separate glob patterns that will pick up pkl files from
the
INDATA/directory and its subdirectories.I'm creating the output directories for plots and data if they do
not exist already.
The plotting functions mysteriously saw a
GNlabel. I'm reallynot sure if this is the right thing to do here, but I simply assumed
that this was the same as
GNDand added another entry to thecolormap accordingly. This may be really a symptom of a bug that
should be fixed in another place.