FIX ModelAdmin::$model_importers alias support#1216
Open
chillu wants to merge 1 commit intosilverstripe:1.8from
Open
FIX ModelAdmin::$model_importers alias support#1216chillu wants to merge 1 commit intosilverstripe:1.8from
chillu wants to merge 1 commit intosilverstripe:1.8from
Conversation
Member
Author
|
Same test failures as upstream |
chillu
force-pushed
the
pulls/1/modeladmin-csv-modelname-alias
branch
from
ce9c294 to
477bb23
Compare
Hasn't been considered when introducing aliases rather than class names in $managed_models. Fixed a regression from when we introduced $modelTab. This is backwards compatible since $modelTab falls back to $modelClass. Also improved $model_importers to fall back to the default per model, rather than requiring definition of *all* models on a non-null value.
chillu
force-pushed
the
pulls/1/modeladmin-csv-modelname-alias
branch
from
477bb23 to
81cf409
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hasn't been considered when introducing aliases rather than class names in $managed_models.