Skip to content

Change ToString to use original rather than foldedCase#2

Open
bergmark wants to merge 1 commit intomasterfrom
no-foldedCase
Open

Change ToString to use original rather than foldedCase#2
bergmark wants to merge 1 commit intomasterfrom
no-foldedCase

Conversation

@bergmark
Copy link
Member

@bergmark bergmark commented Sep 1, 2015

Is there a reason behind using foldedCase? It's unintuitive to me as e.g. toString . mk isn't the identity.

If we change this I think it calls for a major bump.

@hesselink
Copy link
Member

You added it ;) I think you're right, it's probably better to use original. As for laws, fromString . toString = id makes sense to me, but that one holds in either case. I think toString . fromString = id is too string, that removed any opportunity for normalization without storing the original string. So in the end I think this choice is just one of preference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants