Ric/sig 90152 resync fork2 #9

ric-sigma-computing · 2026-01-08T19:19:34Z

Re-sync fork. Move upstream overrideTags to overrideTagsUnoptimized, keep our overrideTags2.

updSocketOptions are set when protocol is `udp` not `uds`. Simple fix!

* Add gaugeDelta implementation * Update type definitions * Add gaugeDelta to statsFunctions * Address double negative * Update README * Add gaugeDelta-specific tests

Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.20.13 to 7.25.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.25.6/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Handle synchronous socket.send error in sendUsingDnsCache We are using UDP with DNS caching in production and noticed the occasional unhandled exception in our application when the datadog agent is unavailable. We tracked it down to the lookup branch of `sendUsingDnsCache` which calls `socket.send` within a callback. `socket.send` can throw a sync exception and not invoke `callback` as described here: https://nodejs.org/api/dgram.html#socketsendmsg-offset-length-port-address-callback. * PR feedback

* Upgrade mocha and package lock for security warning and a few misc README updates * Use older lockfile version * Update changelog * Fix changelog, noticed a very small nan update in lockfile

* Fixes for bdeitte#273 and bdeitte#244 * Fix up the fix and add CLAUDE file * Code review updates * More test fixups * Change Node versions tested and try to help with unix-dgram issue * Attempt to fix Ubuntu test issue

* Add some more tests for uncovered areas * Actually add files * Update changelog * Try to fix up Windows lint issues and remove unneeded tests * Ensure eslint really runs everywhere and fix up tests * Try to fix Windows again

* Add some more tests for uncovered areas * Actually add files * Update changelog * Try to fix up Windows lint issues and remove unneeded tests * Ensure eslint really runs everywhere and fix up tests * Try to fix Windows again * Fix bdeitte#196, bdeitte#260, bdeitte#214

… overrideTags (bdeitte#289)

* Add in debug logging * Code review fixups * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>

* Fix a number of small, old issues * Code review updates and try to fix flakiness in unix builds

* Add in Datadog telemetry * Small fixups * Update lib/statsd.js Co-authored-by: Copilot <[email protected]> * Update lib/telemetry.js Co-authored-by: Copilot <[email protected]> * Fix lint issue * Code review updates * Code review fixups --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Brian Deitte <[email protected]>

…c-fork2 # Conflicts: # .github/workflows/node-test.js.yml # lib/helpers.js # lib/statsd.js # package-lock.json

…deTagsUnoptimized

ric-sigma-computing · 2026-01-08T22:31:20Z

I verified the fix helps with the congestion issue by running a custom build against the wes test

Before you can see the congestion issue causes an error to be propogated to sentry

and after you can see that there are no longer errors propogated to sentry, while we still see the socket datagram "internal error" meaning it's successfully retrying.

ric-sigma-computing · 2026-01-08T23:13:13Z

After enabling client side telemetry, I see that we are sending datadog about 10,000 metrics/second during the load test which was leading to the original congestion issue.

@wesmoncrief Do you have a gut sense of what is the order of magnitude expected? I'm not too sure what the load tests are doing and if this is correct, or maybe we collect too many metrics.

ric-sigma-computing · 2026-01-12T18:07:36Z

@wesmoncrief gentle bump when u get a chance ^

ric-sigma-computing · 2026-01-13T19:35:13Z

@donhcd Added you from Jonathon's suggestion - let me know if a screensharing session to catch you up and review would be helpful.

ric-sigma-computing · 2026-01-15T00:27:01Z

@donhcd Added you from Jonathon's suggestion - let me know if a screensharing session to catch you up and review would be helpful.

@donhcd gentle bump on this review - I've been getting pressured to merge it because it's performance impacting due to the reduction of dns lookup overhead from crossover

donhcd

seems reasonable, just a couple questions

donhcd · 2026-01-15T20:54:18Z

.github/workflows/node.js.yml

why rename the file? I'd think that the less drift we have from hot-shots, the better future rebases etc will be

Only because that's what it's currently named in our fork, I'm not sure why we renamed it originally. I may be suffering from cultural training

donhcd · 2026-01-15T20:54:31Z

.github/workflows/node.js.yml

    runs-on: ${{ matrix.os }}
    steps:
-    - uses: actions/checkout@v6
+    - uses: actions/checkout@v3


was there a problem with v6?

no, like above for the ci stuff i opted to keep our setup. let me use upstream and see if it works

donhcd · 2026-01-15T21:14:32Z

lib/helpers.js

not a comment on this PR directly, but for ease of future rebases it seems like we might as well just keep the existing overrideTags name and just call overrideTags2 in the specific spots where we want to use it...

donhcd · 2026-01-15T21:18:48Z

package-lock.json

why delete this?

There were too many merge conflicts so I regenerated the file. It's not deleted

donhcd · 2026-01-15T21:21:56Z

lib/helpers.js

let's remove this -- seems like we're not using this right now anyways?

as I mentioned in the other comment, though, I'd be on board in the future with just renaming overrideTagsUnoptimized back to overrideTags everywhere

donhcd

lgtm, my comments are non-blocking (but it would be nice to clean this up later). I'm expecting/hoping the tests in this repo, the tests in mono-node, your manual tests, and staging baking should all help catch any bugs we discover 🙃

tebriel and others added 30 commits September 6, 2024 22:14

Fix typo in README.md (bdeitte#267)

37b12b6

updSocketOptions are set when protocol is `udp` not `uds`. Simple fix!

Add gaugeDelta function (bdeitte#259)

beaf59c

* Add gaugeDelta implementation * Update type definitions * Add gaugeDelta to statsFunctions * Address double negative * Update README * Add gaugeDelta-specific tests

Add Node 20 testing (bdeitte#270)

356ac62

Update changelog

1e7dba4

10.1.0

400d0ae

Update changelog

ce84b4e

10.1.1

8983322

Upgrade mocha and package lock for security warning (bdeitte#272)

511b8fa

* Upgrade mocha and package lock for security warning and a few misc README updates * Use older lockfile version * Update changelog * Fix changelog, noticed a very small nan update in lockfile

Add option 'includeDataDogTags' (bdeitte#275)

4430c44

Update changelog

3741711

10.2.0

b803247

Fix two CHANGELOG updates

96186a9

Add 'includeDataDogTags' property to 'ClientOptions' type (bdeitte#276)

d0de2c1

Changelog update

256963e

10.2.1

51bb0c3

Update date in changelog

3fd9489

11.0.0

8f6e10b

Add some more tests for uncovered areas (bdeitte#282)

03a13d9

* Add some more tests for uncovered areas * Actually add files * Update changelog * Try to fix up Windows lint issues and remove unneeded tests * Ensure eslint really runs everywhere and fix up tests * Try to fix Windows again

11.1.0

f1a954a

Fix changes formatting

f72e8bf

Update org name given transfer (bdeitte#288)

1ea5c5d

Given issue 287, reverted the change to improve memory/performance of…

4f176c0

… overrideTags (bdeitte#289)

Upgrade node-unix-dgram (bdeitte#290)

866362c

Upgrade changelog

614c4e4

bdeitte and others added 16 commits November 30, 2025 12:08

11.3.0

48fa9b6

Update build status given new location of aciton

8c309d2

Make clear for latest release that the issue was fixed

a759d1f

Add in debug logging (bdeitte#293)

49ab2ed

* Add in debug logging * Code review fixups * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>

CHANGES update

35ceb56

11.4.0

d0494d3

Fix README mistake

17f7fdc

Fix a number of small, old issues (bdeitte#294)

4cae759

* Fix a number of small, old issues * Code review updates and try to fix flakiness in unix builds

Changelog update

86a8df0

12.0.0

6c4e9ae

Update changelog

7e6696b

12.1.0

e0b251c

Merge remote-tracking branch 'upstream/main' into ric/SIG-90152-resyn…

7f93f45

…c-fork2 # Conflicts: # .github/workflows/node-test.js.yml # lib/helpers.js # lib/statsd.js # package-lock.json

Fix merge conflicts; Copy upstream overrideTags to our copy of overri…

65e58a7

…deTagsUnoptimized

Regenate package-lock.json

7fabaac

ric-sigma-computing requested a review from wesmoncrief January 8, 2026 19:19

Move renamed file back

edff49b

kephams approved these changes Jan 8, 2026

View reviewed changes

ric-sigma-computing requested a review from donhcd January 13, 2026 19:34

donhcd reviewed Jan 15, 2026

View reviewed changes

donhcd approved these changes Jan 15, 2026

View reviewed changes

rename to upstream function. source upstream node-test.js.yml

ce18f4b

ric-sigma-computing merged commit ebfca21 into master Jan 15, 2026
11 checks passed

donhcd deleted the ric/SIG-90152-resync-fork2 branch January 15, 2026 23:57

Ric/sig 90152 resync fork2 #9

Ric/sig 90152 resync fork2 #9

Uh oh!

Conversation

ric-sigma-computing commented Jan 8, 2026

Uh oh!

ric-sigma-computing commented Jan 8, 2026

Uh oh!

ric-sigma-computing commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ric-sigma-computing commented Jan 12, 2026

Uh oh!

ric-sigma-computing commented Jan 13, 2026

Uh oh!

ric-sigma-computing commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

donhcd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

donhcd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

ric-sigma-computing commented Jan 8, 2026 •

edited

Loading

ric-sigma-computing commented Jan 15, 2026 •

edited

Loading