Open
Conversation
…ns a copy such that the immutable reference cannot be changed under the hood when passed to clients
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Andrew
I hope, this pull request is now correct. I switched to Fedora-17 and I think I have created the git stuff exactly in the same way as you showed my at JBW.
I remoted the getRoot() call by modeling the rootElement directly into the descriptor. THis is actually the current solution. I was trying to use the root element because your POC was using the Filter element exclusively. So, I tried to replace the filter element by the root element. Finally, I came back to the current solution, which is simpler.
I need your help for clean up the API regarding the interface definition. All the AppType references are actually not required. I guess, once you have a solution for the mutable - imutable switch, the solution for this is easy.
I synced the my POC with the generated code.
Let me know if there is a problem or an issue.
Regards,
Ralf