Shrinkdesc 92

[rbattenfeld]

Hi Andrew and Jesper

I changed the cli based on your suggestions. You can have a look.

@jesper, I am not so familiar with the mvn antrun plugin but I added a class called 'TransformerTask' which is similar to the ReportTask you have mentioned. I hope you can reuse this class via ant.

What is not covered so far are:

• Test cases are still produced. I don't think we should change here someting. The user can point to something like /dev/null or to a folder in the target directory.
• Producing the service files. Here I am also not so sure about this...

Let me know what has to be improved on this version.

Cheers,
Ralf

[rbattenfeld]

Hi Andrew and Jesper

The cli maven plugin is running. The plugin generates the descriptors according the passed parameters. You can execute the transformation like this example:

org.jboss.shrinkwrap.descriptors shrinkwrap-descriptors-cli-plugin ${project.version} transform install transform ${project.build.directory}/../../cli/src/test/resources/xml/schemasIronJacamar.xml ${project.build.directory}/../../cli-test/src/main/java ${project.build.directory}/../../cli-test/src/test/java ${project.build.directory}/cli true

Note, the can be empty, then no test classes are generated.

Not done so far are:

1. Testing ant task. I don't know if we need to install ant. If yes, then this is maybe not what we want...
2. Generating the service files.

Let me know how to proceed.

Regards,
Ralf

[rbattenfeld]

Hi Andrew

If Bartosz looks at the source code, then it is better to commit everything. So, the latest version includes the following features:

• all descriptors are generated now by the new maven based metadata plugin.
• dtd descriptors are natively supported by using the dtd-parser library
• new are orm_1_0.xsd and orm_2_0.xsd generated. I think, persistence.xml without orm is incomplete.
• as SD-98 requests, configure.dtd (jetty) is generated. I created seperate modules for this (api-misc/impl-misc)
• the service files under META-INF/services can be generated as well

Some general comments about the plugin. The plugin will support much more descriptor out of the box because there are no hacks any more implemented covering a particular descriptor definition. I have to write little more test directly testing XSD specifications but this comes later.

Have fun!

Ralf