product page component to menage brand name simple version - #45
Open
sambakkids wants to merge 5 commits into
Open
product page component to menage brand name simple version#45sambakkids wants to merge 5 commits into
sambakkids wants to merge 5 commits into
Conversation
…xtjs into AKB-64-product-page-component-to-menage-brand-name-simple-version
thibaultrey
reviewed
Jul 13, 2023
thibaultrey
left a comment
thibaultrey
left a comment
Contributor
There was a problem hiding this comment.
Some changes are required on you productBrand component
Comment on lines
+21
to
+27
| computed: { | ||
| productBrandName(): string { | ||
| const brand = this.product?.brand | ||
| const brandName = brand?.brand.name || '' | ||
| return brandName | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I think the computed function is not necessary here because it just return the brand name your can directly add this to your template
{{product?.brand?.name || ''}}
| @@ -0,0 +1,38 @@ | |||
| <template> | |||
| <div class="product-brand"> | |||
Contributor
There was a problem hiding this comment.
you can add v-if condition like that
v-if="product?.brand?.name"
Contributor
There was a problem hiding this comment.
this file changes are not related to your PR topic
thibaultrey
requested changes
Jul 13, 2023
thibaultrey
left a comment
thibaultrey
left a comment
Contributor
There was a problem hiding this comment.
Some files changes are not necessary in this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AKB (Abitare Kids Brands ) is the key used in our jira