Add stroke-width style based on --track-width to <wa-spinner>#1316
Add stroke-width style based on --track-width to <wa-spinner>#1316curtiskeller wants to merge 1 commit intoshoelace-style:nextfrom
stroke-width style based on --track-width to <wa-spinner>#1316Conversation
|
@curtiskeller is attempting to deploy a commit to the Font Awesome Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
We may want to use em units instead of pixels, as this changes makes the spinner look thinner at various sizes. @lindsaym-fa what do you think? Maintainer notes:
|
stroke-width style based on --track-width to <wa-spinner>
|
I fell down a bit of a rabbit hole with this one, but if we'd like to keep the scope of this issue contained, I'd recommend setting It seems because we're setting a And there's the 🐰🕳️: 4px =/= 4px. That's seems...unexpected. For example, here's what Screen.Recording.2025-08-20.at.11.52.07.AM.movNone of those strokes are exactly 4px. The largest example, which uses Here's what Screen.Recording.2025-08-20.at.11.51.40.AM.movWe'd expect the stroke width of the first to render as 4px, the second as 8px, and the third as 12px. Instead, the first looks closer to ~1px, the second ~5px, and the third ~10px. And, notably, the svg starts to be clipped at the largest size. There's more to resolve here to ensure that the applied |
|
Great analysis. I would vote for handling them all together unless there’s a good reason not to. |
|
No problem! Just to confirm, you would like me to change the |
|
No further action required from you right now, @curtiskeller! I'll start digging into how we can fix the sizing for |


Update spinner to respect track width property. Issue #1317